[DO NOT MERGE] ChangeFeed: Adds Full Fidelity Change Feed APIs to GA surface#5825
Open
ananth7592 wants to merge 2 commits intomainfrom
Open
[DO NOT MERGE] ChangeFeed: Adds Full Fidelity Change Feed APIs to GA surface#5825ananth7592 wants to merge 2 commits intomainfrom
ananth7592 wants to merge 2 commits intomainfrom
Conversation
Removes #if PREVIEW guards from 7 types/members to make them unconditionally public, promoting the AllVersionsAndDeletes mode from Preview to GA: 1. ChangeFeedMode.AllVersionsAndDeletes 2. ChangeFeedItem<T> 3. ChangeFeedMetadata 4. ChangeFeedOperationType 5. ChangeFeedPolicy 6. ChangeFeedPolicyDefinition 7. ContainerProperties.ChangeFeedPolicy 8. ContainerBuilder.WithChangeFeedPolicy Updates GA and Preview API contract files accordingly. Closes #5814 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ananth7592
requested review from
FabianMeiswinkel,
Pilchie,
jeet1995,
kirankumarkolli,
kundadebdatta,
kushagraThapar,
sboshra and
xinlian12
as code owners
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
ananth7592
force-pushed
the
users/ananth/ffcf-ga
branch
from
245f7be to
dceb0ad
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
ananth7592
force-pushed
the
users/ananth/ffcf-ga
branch
from
dceb0ad to
36fb41a
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
ananth7592
force-pushed
the
users/ananth/ffcf-ga
branch
from
36fb41a to
19e5c57
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
…llVersionsAndDeletes Moves the abstract method declaration out of the #if PREVIEW block so it compiles into the GA (non-preview) build output. Added a check inside ChangeFeedProcessorCore that skips appending startTime fix done as part of #5617 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ananth7592
force-pushed
the
users/ananth/ffcf-ga
branch
from
19e5c57 to
f5fc04f
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
kushagraThapar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes Full Fidelity Change Feed (FFCF) APIs from preview to the GA surface area, per #5814.
Changes
Testing
Local testing with ChangeFeed
Setup a container with AVAD support
Setup CFP to capture CRUDs. Following example shows "Inserts" and "Deletes"
Screenshots
#5826
Resolves #5814